fix: fix running dhis war using maven jetty plugin #9314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbee
approved these changes
Nov 25, 2021
|
Fix confirmed |
vietnguyen
approved these changes
Nov 25, 2021
https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/server/NCSARequestLog.html was deprecated and subsequently removed Jetty 10 changed quite a lot regarding logging jetty/jetty.project#4572 The Jetty libraries (both client and server) use SLF4J as logging APIs. The only config we had in jetty-logging.properties is thus not needed anymore. There might be other settings we find have changed, that we need to adapt
teleivo
force-pushed
the
jetty-10-maven-plugin
branch
from
e5d04c4 to
b69e20f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.eclipse.org/jetty/javadoc/jetty-9/org/eclipse/jetty/server/NCSARequestLog.html
was deprecated and subsequently removed
Jetty 10 changed quite a lot regarding logging
jetty/jetty.project#4572
there might be other settings we find have changed, that we need to adapt