Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add defaults to optionSetItem [DHIS2-18643] #19536

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

maikelarabori
Copy link
Contributor

We need to return a default “optionSetItem” object to keep the new option set item object backward compatible with existing Visualization and allow clients to distinguish between elements that contain an option set from elements that do not.

To achieve it we have to return something like the snippet below:

columns: [{
	dimension: 'dx',
	items: [{
		name: "Data element with option set",
		optionSetItem: { // Always return below by default, if optionSetItem or aggregation is not set
			aggregation: "AGGREGATED",
		},
	}],
}]

Copy link

sonarqubecloud bot commented Dec 19, 2024

@maikelarabori maikelarabori merged commit 0c43892 into master Dec 19, 2024
20 checks passed
@maikelarabori maikelarabori deleted the DHIS2-18643_2.42 branch December 19, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants