Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support option set in DV object [DHIS2-18370] #19492

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

maikelarabori
Copy link
Contributor

Adds a new object (OptionSetItem) to the Visualization object, so users can save the option set along with the option set items they wish to be saved as part of their Visualization. The aggregation type is also required as the items can be aggregated or disaggregated. It depends on the users' choice.

@maikelarabori maikelarabori added the run-api-analytics-tests Enables analytics e2e tests label Dec 16, 2024
Copy link
Contributor

@gnespolino gnespolino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have e2e test for this

@maikelarabori
Copy link
Contributor Author

would be nice to have e2e test for this

We do not do analytics e2e for tests that persist data @gnespolino. In addition, this is related to a metadata endpoint (not analytics), which we also do not do analytics e2e as they are already tested through integration tests. The integration tests in this PR, for example, extend H2ControllerIntegrationTestBase, which will persist and retrieve the data as part of the test. So we are testing the entire flow for this change (saving, reading, and asserting the response related).

We are not adding any new test that depends on those legacy tests based on metadata JSON files.
Our integration tests can do the same in a cleaner way.

@maikelarabori maikelarabori merged commit 94998b5 into master Dec 17, 2024
17 checks passed
@maikelarabori maikelarabori deleted the DHIS2-18370_2.42 branch December 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-api-analytics-tests Enables analytics e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants