-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support option set in DV object [DHIS2-18370] #19492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to have e2e test for this
We do not do analytics e2e for tests that persist data @gnespolino. In addition, this is related to a metadata endpoint (not analytics), which we also do not do analytics e2e as they are already tested through integration tests. The integration tests in this PR, for example, extend We are not adding any new test that depends on those legacy tests based on metadata JSON files. |
Quality Gate passedIssues Measures |
Adds a new object (
OptionSetItem
) to the Visualization object, so users can save the option set along with the option set items they wish to be saved as part of their Visualization. The aggregation type is also required as the items can be aggregated or disaggregated. It depends on the users' choice.