feat: skipAnalytics and ConfidentialFlag only for QUERY Analytics [DHIS2-18259] #19350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DHIS2-18259] Signed-off-by: Giuseppe Nespolino <[email protected]>
larshelge
reviewed
Dec 1, 2024
...ain/java/org/hisp/dhis/analytics/event/data/DefaultEnrollmentAnalyticsDimensionsService.java
Outdated
Show resolved
Hide resolved
larshelge
reviewed
Dec 1, 2024
...ain/java/org/hisp/dhis/analytics/event/data/DefaultEnrollmentAnalyticsDimensionsService.java
Show resolved
Hide resolved
larshelge
reviewed
Dec 1, 2024
...analytics/src/main/java/org/hisp/dhis/analytics/event/data/DefaultEventDataQueryService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Giuseppe Nespolino <[email protected]>
Signed-off-by: Giuseppe Nespolino <[email protected]>
gnespolino
requested review from
luciano-fiandesio,
vietnguyen and
maikelarabori
larshelge
reviewed
Dec 2, 2024
...analytics/src/main/java/org/hisp/dhis/analytics/event/data/DefaultEventDataQueryService.java
Outdated
Show resolved
Hide resolved
larshelge
reviewed
Dec 2, 2024
| new ErrorMessage( | ||
| ErrorCode.E7240, | ||
| skipAnalyticsDataElements.stream() | ||
| .map(DataElement::getDisplayName) |
There was a problem hiding this comment.
I think we usually use uid in API validation responses as it is more compact.
larshelge
reviewed
Dec 2, 2024
...analytics/src/main/java/org/hisp/dhis/analytics/event/data/DefaultEventDataQueryService.java
Show resolved
Hide resolved
…ytics_Confidential # Conflicts: # dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcEnrollmentAnalyticsTableManager.java # dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcEventAnalyticsTableManager.java
…ntial' into DHIS-18259_skipAnalytics_Confidential
Signed-off-by: Giuseppe Nespolino <[email protected]>
...analytics/src/main/java/org/hisp/dhis/analytics/event/data/DefaultEventDataQueryService.java
Outdated
Show resolved
Hide resolved
larshelge
approved these changes
Dec 2, 2024
Signed-off-by: Giuseppe Nespolino <[email protected]>
…ntial' into DHIS-18259_skipAnalytics_Confidential
|
maikelarabori
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the handling of
confidentialTracked Entity Attributes (TEA) and Program Attributes (PA), as well asskipAnalyticsdata elements (DE).Key Changes:
TEA/PAandDEare now consistently exported, irrespective of theconfidentialorskipAnalyticsflags.TEA/PA/DEwith theconfidentialorskipAnalyticsflags inQUERYendpoints.confidentialTEA/PAandskipAnalyticsDEis now supported inAGGREGATEanalytics.