Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: expect node.js on build machine [2.39] #18892

Merged
merged 1 commit into from
Oct 23, 2024
Merged

ci: expect node.js on build machine [2.39] #18892

merged 1 commit into from
Oct 23, 2024

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Oct 22, 2024

backport of

manual tests

  • ./dhis-2/build-dev.sh && docker compose up locally and check apps are bundled
  • deploy PR to instance manager and check apps are bundled
  • run mvn clean test and mvn clean test with individual profiles and double-check sum of tests is equal

@teleivo teleivo changed the title ci: expect node.js on build machine ci: expect node.js on build machine [2.39] Oct 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@teleivo teleivo added the deploy Deploy DHIS2 instance with IM. label Oct 22, 2024
@teleivo teleivo marked this pull request as ready for review October 22, 2024 16:08
@teleivo teleivo merged commit 900f131 into 2.39 Oct 23, 2024
11 of 12 checks passed
@teleivo teleivo deleted the ci-tests-39 branch October 23, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radnov radnov radnov approved these changes

@netroms netroms Awaiting requested review from netroms

@jbee jbee Awaiting requested review from jbee

@enricocolasante enricocolasante Awaiting requested review from enricocolasante

Assignees
No one assigned
Labels
deploy Deploy DHIS2 instance with IM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teleivo @radnov