fix: set sms.createdBy consumer thread DHIS2-18187 [2.41]

[teleivo]

Issue

The UserDetails refactoring in 41 broke incoming SMS processing.

The sms processing code

• dhis2-core/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/sms/listener/CommandSMSListener.java

  Line 241 in db185d6

  UserInfoSnapshot.from(CurrentUserUtil.getCurrentUserDetails());

• and any code then using hibernate to update the IncomingSms state

  dhis2-core/dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/hibernate/HibernateIdentifiableObjectStore.java

  Lines 173 to 175 in db185d6

  	UserDetails currentUserDetails = CurrentUserUtil.getCurrentUserDetails();
  	if (currentUserDetails == null) {
  	throw new IllegalArgumentException("Current user is not set, can not update object");

Fix

• Set the system user in the sms consumer thread.
• Use stream instead of parallelStream as we would need to set the user on those threads as well. We used the same strategy on master in tracker. We are not sure how many people actually use the inbound sms feature in tracker.
• Use the sms.createdBy user when setting fields like storedBy as it contains the user that sent the sms found/set by the SmsInboundController.getUserByPhoneNumber. The user that sent the sms is the one responsible for creating/updating/deleting events and other entities.

dhis2-core/dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/sms/SmsInboundController.java

Lines 102 to 120 in db185d6

	long smsId =
	incomingSMSService.save(
	message,
	originator,
	gateway,
	receivedTime,
	getUserByPhoneNumber(originator, message, currentUser));
	return ok("Received SMS: " + smsId);
	}
	@PostMapping(consumes = APPLICATION_JSON_VALUE, produces = APPLICATION_JSON_VALUE)
	@PreAuthorize("hasRole('ALL') or hasRole('F_MOBILE_SETTINGS')")
	@ResponseBody
	public WebMessage receiveSMSMessage(HttpServletRequest request, @CurrentUser User currentUser)
	throws WebMessageException, IOException {
	IncomingSms sms = renderService.fromJson(request.getInputStream(), IncomingSms.class);
	sms.setCreatedBy(getUserByPhoneNumber(sms.getOriginator(), sms.getText(), currentUser));

Tests

I cannot backport the automated tests created on master during https://dhis2.atlassian.net/browse/DHIS2-17729. This would take weeks or more. I briefly tried backporting one but we cannot use controller tests as they cannot be non-transactional in 41. The sms are consumed in another thread so we have the issue of the test transaction isolating us from that thread.

Manual tests

• sent sms shown in https://dhis2.atlassian.net/browse/DHIS2-18187

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud