Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use tomcat 10 for dev #18756

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: use tomcat 10 for dev #18756

merged 1 commit into from
Oct 4, 2024

Conversation

vietnguyen
Copy link
Contributor

No description provided.

@vietnguyen vietnguyen requested a review from a team as a code owner October 4, 2024 09:06
@vietnguyen vietnguyen enabled auto-merge (squash) October 4, 2024 09:08
@radnov
Copy link
Contributor

radnov commented Oct 4, 2024

We need to update the tomcat base image version in the stable pipeline, too:

dhis2-core/jenkinsfiles/stable

Line 38 in 2389beb

DOCKER_IMAGE_NAME_PUBLISH_SOURCE = "tomcat:9.0-jre17" // source of image to publish to Dockerhub (one of the matrix axes)

dhis2-core/jenkinsfiles/stable

Line 73 in 2389beb

values '9.0-jre17', '8.5-jre17'

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vietnguyen vietnguyen merged commit 82e517a into master Oct 4, 2024
14 checks passed
@vietnguyen vietnguyen deleted the fix-tomcat-version branch October 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-mackessy david-mackessy david-mackessy approved these changes

@tonsV2 tonsV2 tonsV2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vietnguyen @radnov @tonsV2 @david-mackessy