test: allow non-transactional controller integration tests DHIS2-17729 #18731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
requested review from
jbee,
enricocolasante,
david-mackessy and
vietnguyen
enricocolasante
approved these changes
Oct 3, 2024
netroms
approved these changes
Oct 3, 2024
by moving the @transactional annotation from our ControllerIntegrationTestBase to the test itself. We did the same for our service/repo integration tests already.
teleivo
force-pushed
the
DHIS2-17729-non-transactional-controller-test
branch
from
18558d4 to
10ba6c2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by moving the
@Transactionalannotation from our ControllerIntegrationTestBase to the test itself. We did the same for our service/repo integration tests already.It was already approved in the past #18470 I closed it as I did not have a test that needed this change.
I now have the first controller integration test
#18719
that tests tracker code running in another thread. I therefore need a non-transactional controller integration test.