Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary calls to the DB during DataValueSet import [D… #15645

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

david-mackessy
Copy link
Contributor

…HIS2-16138]
backport of #15639

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #15645 (313e3f4) into 2.39 (886690f) will increase coverage by 6.19%.
Report is 110 commits behind head on 2.39.
The diff coverage is 66.78%.

@@             Coverage Diff              @@
##               2.39   #15645      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.19%     
- Complexity    25817    28690    +2873     
============================================
  Files          3207     3212       +5     
  Lines        121397   121812     +415     
  Branches      14158    14220      +62     
============================================
+ Hits          71118    78902    +7784     
+ Misses        44340    36422    -7918     
- Partials       5939     6488     +549     
Flag Coverage Δ
integration 48.56% <37.84%> (-0.03%) ⬇️
integration-h2 33.97% <18.28%> (?)
unit 29.54% <44.21%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 111 more

... and 545 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ac321...313e3f4. Read the comment docs.

@david-mackessy david-mackessy merged commit 33b26fa into 2.39 Nov 10, 2023
12 checks passed
@david-mackessy david-mackessy deleted the DHIS2-16138_2.39 branch November 10, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants