Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove renamed job from DB [DHIS2-15276] #15628

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Nov 8, 2023

In #15575 the heartbeat job got renamed but I forgot to remove existing row from DB so they would not cause errors on load when trying to map their job type value to JobType enum.

@jbee jbee self-assigned this Nov 8, 2023
@jbee jbee enabled auto-merge (squash) November 8, 2023 13:26
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #15628 (fbaaa15) into master (1a07024) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15628   +/-   ##
=========================================
  Coverage     66.19%   66.20%           
- Complexity    31256    31258    +2     
=========================================
  Files          3487     3487           
  Lines        129879   129879           
  Branches      15166    15166           
=========================================
+ Hits          85979    85986    +7     
+ Misses        36814    36809    -5     
+ Partials       7086     7084    -2     
Flag Coverage Δ
integration 49.79% <ø> (+<0.01%) ⬆️
integration-h2 32.40% <ø> (ø)
unit 30.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5086fe...fbaaa15. Read the comment docs.

@jbee jbee merged commit 3e25726 into dhis2:master Nov 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants