Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade to correct rule-engine version [DHIS2-15261] (#15347) #15387

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

enricocolasante
Copy link
Contributor

No description provided.

@enricocolasante enricocolasante marked this pull request as ready for review October 12, 2023 16:26
@enricocolasante enricocolasante enabled auto-merge (squash) October 12, 2023 16:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #15387 (a7bbe54) into 2.39 (886690f) will increase coverage by 6.18%.
Report is 81 commits behind head on 2.39.
The diff coverage is 68.15%.

@@             Coverage Diff              @@
##               2.39   #15387      +/-   ##
============================================
+ Coverage     58.58%   64.76%   +6.18%     
- Complexity    25817    28647    +2830     
============================================
  Files          3207     3212       +5     
  Lines        121397   121743     +346     
  Branches      14158    14202      +44     
============================================
+ Hits          71118    78852    +7734     
+ Misses        44340    36401    -7939     
- Partials       5939     6490     +551     
Flag Coverage Δ
integration 48.56% <29.61%> (-0.04%) ⬇️
integration-h2 34.30% <26.76%> (?)
unit 29.54% <41.26%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 90 more

... and 555 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9fe29...a7bbe54. Read the comment docs.

@enricocolasante enricocolasante requested a review from a team October 12, 2023 16:46
@enricocolasante enricocolasante merged commit 6a7bba1 into 2.39 Oct 13, 2023
@enricocolasante enricocolasante deleted the DHIS2-15261-2.39 branch October 13, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants