Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust options dialog for easier scanning #580

Merged
merged 2 commits into from
Jan 30, 2020
Merged

fix: adjust options dialog for easier scanning #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1554df6
fix: styling for options dialog sections
cooper-joe Jan 29, 2020
f0f7cc4
fix: width for range axis decimals/steps to allow placeholder text
cooper-joe Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/components/VisualizationOptions/Options/RangeAxisDecimals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import TextBaseOption from './TextBaseOption'
const RangeAxisDecimals = () => (
<TextBaseOption
type="number"
width="72px"
width="96px"
label={i18n.t('Decimals')}
placeholder={i18n.t('Auto')}
option={{
Expand Down
2 changes: 1 addition & 1 deletion packages/app/src/components/VisualizationOptions/Options/RangeAxisSteps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import TextBaseOption from './TextBaseOption'
export const RangeAxisSteps = () => (
<TextBaseOption
type="number"
width="72px"
width="96px"
helpText={i18n.t(
'The number of axis steps between the min and max values'
)}
Expand Down
10 changes: 8 additions & 2 deletions packages/app/src/components/VisualizationOptions/styles/VisualizationOptions.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ export const tabSection = css.resolve`
div {
padding: ${spacers.dp16} 0;
}
div:not(:last-child) {
border-bottom: 1px solid ${colors.grey300};
margin-bottom: ${spacers.dp8};
}
`

export const tabSectionContent = css.resolve`
Expand All @@ -25,9 +29,11 @@ export const tabSectionContent = css.resolve`
export const tabSectionTitle = css.resolve`
span {
display: inline-block;
padding-bottom: ${spacers.dp16};
font-size: ${spacers.dp16};
padding-bottom: ${spacers.dp12};
font-size: 15px;
color: ${colors.grey900};
font-weight: 500;
letter-spacing: 0.2px;
}
`

Expand Down