Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable ou tree and levels/groups with user orgunits and display decent title (DHIS2-18066) #3241

Merged
merged 14 commits into from
Dec 3, 2024

Conversation

janhenrikoverland
Copy link
Collaborator

@janhenrikoverland janhenrikoverland commented Oct 10, 2024

Implements DHIS2-18066

Requires dhis2/analytics#1702

Support for user orgunit display names. Translations also supported.

The default metadata (user orgunits and relative periods) are now the actual default metadata, defined in the reducer, rather than being dispatched on app load, which seems unnecessary. The reducer also makes sure that this metadata never get overwritten with e.g. values coming from the server as they're translated by the client.


TODO

  • Manual testing

Screenshots

For ou selector see dhis2/analytics#1702

Screenshot from 2024-11-21 15-52-41

Screenshot from 2024-11-25 15-37-13

image

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Oct 10, 2024

🚀 Deployed on https://pr-3241.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify October 10, 2024 09:56 Inactive
@jenniferarnesen jenniferarnesen added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Oct 10, 2024
Copy link

cypress bot commented Oct 10, 2024

Data Visualizer App    Run #2971

Run Properties:  status check passed Passed #2971  •  git commit cdd22e4480 ℹ️: Merge b5c690cfcf8b495105a88ef1e94821f662e57405 into fe6f74eb28cb826d575fe1fbf458...
Project Data Visualizer App
Branch Review fix/enable-user-ou-and-groups
Run status status check passed Passed #2971
Run duration 09m 14s
Commit git commit cdd22e4480 ℹ️: Merge b5c690cfcf8b495105a88ef1e94821f662e57405 into fe6f74eb28cb826d575fe1fbf458...
Committer Jan Henrik Øverland
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 733
View all changes introduced in this branch ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 14:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 25, 2024 14:44 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2024 12:24 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2024 13:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2024 14:20 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2024 14:57 Inactive
@janhenrikoverland janhenrikoverland changed the title fix: enable ou tree and levels/groups with user orgunits and display decent title fix: enable ou tree and levels/groups with user orgunits and display decent title (DHIS2-18066) Nov 28, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify December 2, 2024 15:19 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 09:50 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 10:04 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 3, 2024 21:21 Inactive
@janhenrikoverland janhenrikoverland merged commit ef314a5 into master Dec 3, 2024
30 of 31 checks passed
@janhenrikoverland janhenrikoverland deleted the fix/enable-user-ou-and-groups branch December 3, 2024 21:43
dhis2-bot added a commit that referenced this pull request Dec 3, 2024
## [100.8.6](v100.8.5...v100.8.6) (2024-12-03)

### Bug Fixes

* enable ou tree and levels/groups with user orgunits and display translated title (DHIS2-18066) ([#3241](#3241)) ([ef314a5](ef314a5))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.8.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants