-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable ou tree and levels/groups with user orgunits and display decent title (DHIS2-18066) #3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Deployed on https://pr-3241.data-visualizer.netlify.dhis2.org |
jenniferarnesen
added
the
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
label
Oct 10, 2024
Data Visualizer App Run #2971
Run Properties:
|
Project |
Data Visualizer App
|
Branch Review |
fix/enable-user-ou-and-groups
|
Run status |
Passed #2971
|
Run duration | 09m 14s |
Commit |
cdd22e4480 ℹ️: Merge b5c690cfcf8b495105a88ef1e94821f662e57405 into fe6f74eb28cb826d575fe1fbf458...
|
Committer | Jan Henrik Øverland |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
733
|
View all changes introduced in this branch ↗︎ |
janhenrikoverland
changed the title
fix: enable ou tree and levels/groups with user orgunits and display decent title
fix: enable ou tree and levels/groups with user orgunits and display decent title (DHIS2-18066)
Nov 28, 2024
jenniferarnesen
approved these changes
Dec 3, 2024
dhis2-bot
added a commit
that referenced
this pull request
Dec 3, 2024
## [100.8.6](v100.8.5...v100.8.6) (2024-12-03) ### Bug Fixes * enable ou tree and levels/groups with user orgunits and display translated title (DHIS2-18066) ([#3241](#3241)) ([ef314a5](ef314a5))
🎉 This PR is included in version 100.8.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
e2e record
Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-18066
Requires dhis2/analytics#1702
Support for user orgunit display names. Translations also supported.
The default metadata (user orgunits and relative periods) are now the actual default metadata, defined in the reducer, rather than being dispatched on app load, which seems unnecessary. The reducer also makes sure that this metadata never get overwritten with e.g. values coming from the server as they're translated by the client.
TODO
Screenshots
For ou selector see dhis2/analytics#1702