-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 100.2.0 #2741
Merged
Merged
feat: 100.2.0 #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag builds were not triggering creation of corresponding branch in d2-ci repo. The core apps-to-bundle depends on these.
Automatically merged.
Automatically merged.
Automatically merged.
Automatically merged.
…ing with instances reset (#2500)
#2322) * fix: inject style in props passed to VisualizationPlugin style is used to compute the correct width when toggling the legend panel in dashboard. style is not passed in props from dashboard because doing so can cause re-rendering of the whole iframe tag which causes refetching of the plugin and everything else (analytics included). * refactor: move the size logic from the plugin wrapper This is because eventually the PluginWrapper component will be replaced by the generic one from app-platform. If possible all custom logic should not be put in other components at the app level. * fix: observe size changes for legend positioning * refactor: rename const for clarity It's a callback ref, not a normal ref. --------- Co-authored-by: Jan Henrik Øverland <[email protected]> Co-authored-by: Martin <[email protected]>
The servers are currently slow and there will be very little frontend or backend activity during July 2023
Automatically merged.
* feat: use Toolbar and ToolbarSidebar from analytics * feat: use UpdateButton and HoverMenubar from analytics * feat: update download menu to use hovermenu components from analytics * feat: use hover menu components from analytics for options menu * feat: use interpretations button from analytics * chore: update pot file * chore: upgrade @dhis2/analytics to latest * chore: fix typo in component name * fix: adjust e2e element slectors * chore: fix missing and redundant imports * chore: fix odd linter error which only fires on ci * fix: adjust data test name * chore: fix lines e2e test * fix: adjust closeFileMenuWithClick command * chore: fix failing legens e2e test * chore: fix legend e2e test even better * chore: fix scatter e2e * chore: fix icon e2e * chore: fix start e2e * chore: clean up unused imports * fix: remove divider from plain data source submenu * chore: upgrade @dhis2/analytics to get toolbar UI improvements * fix: tweak viz type selector styles to match toolbar * chore: remove yarn start command which was only used for development * chore: upgrade analytics to get decreased padding * fix: ensure `MenuSectionHeader` is `dense` when in `HoverMenuBar` --------- Co-authored-by: Jan Henrik Øverland <[email protected]>
🚀 Deployed on https://pr-2741--dhis2-data-visualizer.netlify.app |
chore: upgrade cypress to v12
Passing run #2314 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
#2322) * fix: inject style in props passed to VisualizationPlugin style is used to compute the correct width when toggling the legend panel in dashboard. style is not passed in props from dashboard because doing so can cause re-rendering of the whole iframe tag which causes refetching of the plugin and everything else (analytics included). * refactor: move the size logic from the plugin wrapper This is because eventually the PluginWrapper component will be replaced by the generic one from app-platform. If possible all custom logic should not be put in other components at the app level. * fix: observe size changes for legend positioning * refactor: rename const for clarity It's a callback ref, not a normal ref. --------- Co-authored-by: Jan Henrik Øverland <[email protected]> Co-authored-by: Martin <[email protected]>
Servers are currently slow. Will be little activity during July 2023.
Automatically merged.
* feat: use Toolbar and ToolbarSidebar from analytics * feat: use UpdateButton and HoverMenubar from analytics * feat: update download menu to use hovermenu components from analytics * feat: use hover menu components from analytics for options menu * feat: use interpretations button from analytics * chore: update pot file * chore: upgrade @dhis2/analytics to latest * chore: fix typo in component name * fix: adjust e2e element slectors * chore: fix missing and redundant imports * chore: fix odd linter error which only fires on ci * fix: adjust data test name * chore: fix lines e2e test * fix: adjust closeFileMenuWithClick command * chore: fix failing legens e2e test * chore: fix legend e2e test even better * chore: fix scatter e2e * chore: fix icon e2e * chore: fix start e2e * chore: clean up unused imports * fix: remove divider from plain data source submenu * chore: upgrade @dhis2/analytics to get toolbar UI improvements * fix: tweak viz type selector styles to match toolbar * chore: remove yarn start command which was only used for development * chore: upgrade analytics to get decreased padding * fix: ensure `MenuSectionHeader` is `dense` when in `HoverMenuBar` --------- Co-authored-by: Jan Henrik Øverland <[email protected]>
chore: upgrade cypress to v12
…p into release/100.2.0
🎉 This PR is included in version 100.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.