Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: extend timeout for loading visualizations #2368

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

martinkrulltott
Copy link
Contributor

extends the timeout for when visualizations are loading since that seems to be slow sometimes (which could be because of the server), e.g. this test failed when trying to open a PR because the result didn't return fast enough https://cloud.cypress.io/projects/sojh88/runs/2000/test-results/834f2e45-c119-4b4f-9c08-d7f95653be2b

@dhis2-bot
Copy link
Contributor

@dhis2-bot dhis2-bot temporarily deployed to netlify June 1, 2023 11:38 Inactive
Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

40s is quite a long wait, but if that's what it takes 👍

@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #2001 ↗︎

0 625 0 0 Flakiness 0

Details:

Merge a006d33 into 78a2d0e...
Project: Data Visualizer App Commit: 07dfca792b ℹ️
Status: Passed Duration: 09:27 💡
Started: Jun 1, 2023 11:42 AM Ended: Jun 1, 2023 11:52 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@martinkrulltott martinkrulltott merged commit 38fc63b into master Jun 1, 2023
@martinkrulltott martinkrulltott deleted the test/loading-vis-timeout branch June 1, 2023 11:54
@janhenrikoverland janhenrikoverland restored the test/loading-vis-timeout branch June 2, 2023 09:45
martinkrulltott added a commit that referenced this pull request Jun 6, 2023
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants