fix: Decimals and Steps options only allow positive values (DHIS2-9002, DHIS2-9194) #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
commented
Jul 28, 2020
packages/app/src/components/VisualizationOptions/Options/RangeAxisSteps.js
Outdated
Show resolved
Hide resolved
packages/app/src/components/VisualizationOptions/Options/PositiveNumberBaseType.js
Show resolved
Hide resolved
dhis2-bot
added a commit
that referenced
this pull request
Aug 14, 2020
## [35.7.1](v35.7.0...v35.7.1) (2020-08-14) ### Bug Fixes * Decimals and Steps options only allow positive values (DHIS2-9002, DHIS2-9194) ([#1161](#1161)) ([f29e13c](f29e13c))
|
🎉 This PR is included in version 35.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Aug 25, 2020
## [34.6.14](v34.6.13...v34.6.14) (2020-08-25) ### Bug Fixes * change help text for aggregation type ([#1151](#1151)) ([#1209](#1209)) ([b9c3519](b9c3519)) * Decimals and Steps options only allow positive values (DHIS2-9002, DHIS2-9194) ([#1161](#1161)) v34 ([#1210](#1210)) ([b099607](b099607)) * reorder options for consistency (DHIS2-9004) (519b0ba) v34 ([#1211](#1211)) ([8c59852](8c59852))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-9002, DHIS2-9194
Based on playground PoC
DecimalsandStepscould previously be entered as negative numbers and decimal values, which was incorrect. This change prevents this behaviour and only allows positive whole numbers, e.g.0,1,2. Negative values willundefined, which in turn displays the placeholder. Note that forDecimals,0andundefinedoutputs the same result (no decimals shown), while forSteps,0means no steps whileundefineddisplays the default amount of steps set by Highcharts.PositiveNumberBaseTypeadded that only allows positive whole numbersMath.roundprevents decimal numbers and returnsNumberinstead ofString,which fixes DHIS2-9194parseInt(value, 10)to allow for clearing the value with backspaceExample input and expected output:
->kept as is->0->rounded (to 2 and 1 respectively)->0->undefined