-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: working translations [v32] #1001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinkrulltott
approved these changes
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not tested locally. Found 2 cases of yarn duplicates, as per comments below. Can be fixed with npx yarn-deduplicate --packages PACKAGENAME yarn.lock
dhis2-bot
added a commit
that referenced
this pull request
Jun 8, 2020
# [32.1.0](v32.0.3...v32.1.0) (2020-06-08) ### Bug Fixes * upgrade d2-ui dependencies for latest translations [v32] [DHIS2-8892] ([#1061](#1061)) ([6bc2f8c](6bc2f8c)) * **translations:** sync translations from transifex (v32) ([ff4839e](ff4839e)) * **translations:** sync translations from transifex (v32) ([bb026d0](bb026d0)) * **translations:** sync translations from transifex (v32) ([c15e3b6](c15e3b6)) * **translations:** sync translations from transifex (v32) ([0620c69](0620c69)) * @dhis2/[email protected] ([4ed10df](4ed10df)) * allow : after bold and italic ([#314](#314)) ([59aed20](59aed20)) * changed height to min-height for the axes area ([#361](#361)) ([#366](#366)) ([5848460](5848460)) * [email protected] ([27eff19](27eff19)) * deep check styles for changes ([#283](#283)) ([e76555c](e76555c)) * display 'and x others...' on tooltip (DHIS2-8753) v32 backport ([#945](#945)) ([0590fdf](0590fdf)), closes [#927](#927) [#925](#925) * epi curve bug (v32) ([#529](#529)) ([2908206](2908206)) * epi curve bug v32 (v2) ([#530](#530)) ([de40d3d](de40d3d)) * Fetching analytics for analytical object with undefined aggregationType in plugin ([#232](#232)) ([bfe41b4](bfe41b4)) * Fetching analytics for year over year charts in plugin ([#231](#231)) ([16853ef](16853ef)) * manifest credentials bug in chrome ([#233](#233)) ([a0032e0](a0032e0)) * merge conflict ([#545](#545)) ([8e5f7aa](8e5f7aa)) * pie tooltip v32 ([#332](#332)) ([77b2628](77b2628)) * plugin - add deep checks to determine whether to redraw chart ([#284](#284)) ([4b8837e](4b8837e)) * remove api.baseUrl duplicate ([#571](#571)) ([fafd58e](fafd58e)) * v32 backport, upgraded to Analytics v2.4.7 to support long dimension names (DHIS2-7932) ([#622](#622)) ([2cd524a](2cd524a)) * working translations [v32] ([#1001](#1001)) ([c32c623](c32c623)) ### Features * dual axis support ([#239](#239)) ([a50075c](a50075c)) * multiple org units support ([#333](#333)) ([6392efa](6392efa)) ### Reverts * Revert "fix: use lerna to share code instead of copying resources (#214)" (#216) ([de00b4f](de00b4f)), closes [#214](#214) [#216](#216)
🎉 This PR is included in version 32.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of fix for: https://jira.dhis2.org/browse/DHIS2-8638
Part of fix for: https://jira.dhis2.org/browse/DHIS2-8892
Changes are basically the same as for v33, with a few minor differences. Looking to have as little change surface area as possible