fix: use new TranslationDialog component #2111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a screenshot to the description? |
|
Remember to yarn remove package d2-ui-translation-dialog |
|
🚀 Deployed on https://pr-2111--dhis2-dashboard.netlify.app |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I found a bug. To reproduce:
|
jenniferarnesen
requested changes
Oct 6, 2022
This has been replaced with the new component in analytics
edoardo
force-pushed
the
feat/use-new-translation-component
branch
from
3503e54 to
8b3b87c
Compare
This fixes an issue where when going offline/online a request to fetch the translation was triggered resulting in an error when offline. The request is unnecessary anyway, since if online it happens anyway, and when offline does not make sense since it can only fail without network.
jenniferarnesen
approved these changes
Oct 18, 2022
dhis2-bot
added a commit
that referenced
this pull request
Oct 18, 2022
## [99.10.2](v99.10.1...v99.10.2) (2022-10-18) ### Bug Fixes * use new TranslationDialog component ([#2111](#2111)) ([ce58d7f](ce58d7f))
|
🎉 This PR is included in version 99.10.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
edoardo
added a commit
that referenced
this pull request
May 10, 2023
(cherry picked from commit ce58d7f)
edoardo
added a commit
that referenced
this pull request
May 24, 2023
(cherry picked from commit ce58d7f)
janhenrikoverland
pushed a commit
that referenced
this pull request
May 24, 2023
* chore: convert to functional component (cherry picked from commit 4f0abd8) * feat: enable EVENT_VISUALIZATION dashboard item types (cherry picked from commit 1dd409c) * feat: allow iframe plugin overrides for dev/test (cherry picked from commit f79f622) * feat: render LL plugin in iframe (cherry picked from commit 29c5397) * chore: add dependency for post-robot (cherry picked from commit 9300b81) * chore: update pot file (cherry picked from commit cd4ef81) * fix: lookup in installed apps for the plugin URL to use in the iframe (cherry picked from commit e733903) * chore: remove TODO comment (cherry picked from commit 1e0f641) * chore: update pot file (cherry picked from commit 7144805) * chore: add handy deduplicate yarn command (cherry picked from commit f38c3b1) * fix: fix ui dependency (cherry picked from commit b887981) * chore: run prettier (cherry picked from commit b857e9c) * refactor: rewrite condition for better readability (cherry picked from commit 010be92) * fix: remove Suspense which might interfere with the iframe (cherry picked from commit d33336b) * fix: ensure the selector content fits in the container This is a ui issue: dhis2/ui#1152. (cherry picked from commit 322dde1) * refactor: use Layer + Popper to avoid bottom double border (cherry picked from commit cd0751d) * fix: remove redundant overflow rule, fixed in ui This reverts commit a36ab37. (cherry picked from commit f4cad7b) * chore: deduplicate yarn.lock (cherry picked from commit 2b4ad23) * refactor: preserve height/width if provided, update props passed (cherry picked from commit e2fca17) * chore: remove unused import (cherry picked from commit 2f00bbe) * feat: add recording props to plugin (#2125) * fix(pwa): make cache filters more specifc * feat(plugins): add `record` prop to iframe plugins when caching dashboard * feat: remove cached plugin data with dashboard (cherry picked from commit 8cb24db) * chore: run Prettier (cherry picked from commit f50c4bb) * fix: pass correct prop for display property Also do not pass the whole userSettings object, not used in the plugins where the only thing really needed is the displayProperty for the analytics request. (cherry picked from commit a41f0ca) * fix: add more paths to omit from cache Replaced deprecated config key with new one. (cherry picked from commit d1fc48a) * fix: show error when iframe src is not available Also avoid adding postRobot handlers when the iframeRef is not available, this removes some extra errors. (cherry picked from commit 517fc06) * fix: do not pass filtered AO to LL plugin Filters don't work in LL without modifications. For now just disable filtering for LL items. (cherry picked from commit 8a06190) * fix: set error when pluginLaunchUrl is not available The app could be installed and the entry in apps api returned, but the plugin launch URL can be missing, in that case the plugin cannot be loaded in the iframe. (cherry picked from commit d6e703e) * refactor: use specific reducer selector (cherry picked from commit f952cfd) * fix: remove View As in context menu for LL items (cherry picked from commit b777a0d) * fix: clear selected from Redux when editing a new dashboard (cherry picked from commit 440f7c4) * feat: add tags on item header, used for filters in LL For LL items we don't apply filters. Show a tag in the item header to indicate this to the user. (cherry picked from commit 5683b14) * feat: add overlay on LL items to inform about not applied filters (cherry picked from commit 14d814e) * refactor: move the overlay handling to the parent component In this way both the tag in the item header and the overlay in the item content can be controlled at the same time allowing for toggling the tag depending on whether the overlay is shown or not. (cherry picked from commit dbd51ad) * fix: remove tag icon and fix styles Approved by Joe. (cherry picked from commit d15bae0) * fix: remove context menu when plugin is not installed * fetch schema for eventVisualizations, required by the interpretations component (cherry picked from commit 07bd0fc) * fix: rename Event visualizations to Line lists This appears as section title in the dashboard item search. (cherry picked from commit 14e2cea) * feat: add custom message for when the plugin is not installed More friendly than the generic error message. In this case there isn't any problem with the dashboard item, but the plugin for rendering the item is not installed. We inform the user about it and suggest to install the missing app from the app hub. (cherry picked from commit d9a7f0b) * refactor: propagate d2 needed to check installed apps (cherry picked from commit df797dd) * chore: update d2-ui-interpretations component (cherry picked from commit 520903f) * fix: fix re-render of visualizations when interpretations panel toggles (#2199) (cherry picked from commit 50a6b8d) * fix: detect plugin availability via plugin launch URL (cherry picked from commit 48b27e9) * chore: remove accidentally committed temp files (cherry picked from commit 4f79a95) * fix: use new TranslationDialog component (#2111) (cherry picked from commit ce58d7f) * fix: fix linting errors * test: fix failing tests * fix: add missing pieces to make LL plugin work * chore: generate pot file * chore: deduplicate yarn * fix: fix CSS class name used for error/warning messages * fix: pass the correct function to the Map plugin * fix: remove unused code * fix: use first of type logic also in edit and print mode * test: fix tests and snapshots * fix: use first of type logic also in print mode * fix: fix filtering for Maps dashboard items * fix: fix props passed to error component * fix: fix filter version prop handling * chore: deduplicate yarn.lock --------- Co-authored-by: Kai Vandivier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires dhis2/analytics#1342
Replace the old
d2-uicomponent with the new one from analytics.Screenshot