Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix greenkeeper.json #15

Merged
merged 1 commit into from
Mar 5, 2019
Merged

chore: fix greenkeeper.json #15

merged 1 commit into from
Mar 5, 2019

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 5, 2019

Use 4-space tabs and add missing package.json reference

@amcgee
chore: fix greenkeeper.json
7045118 
Use 4-space tabs and add missing package.json reference
@amcgee amcgee requested a review from varl March 5, 2019 06:51
@varl
Copy link
Contributor

varl commented Mar 5, 2019

I changed d2 style js to only hit javascript files btw, so when greenkeeper re-enabled on this repo it wrote it with it's own format (2-spaces).

@varl varl merged commit 2fdc260 into master Mar 5, 2019
@varl varl deleted the chore/fix-greenkeeper-json branch March 5, 2019 10:08
@amcgee
Copy link
Member Author

amcgee commented Mar 5, 2019

@varl yep, d2 style js check only hits javascript files but d2 style js apply hits css and json as well (see dhis2/cli-style#20)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varl varl varl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amcgee @varl