feat: show eslint warnings #368
Conversation
This removes the `--quiet` flag from the ESLint invocation, and fixes the broken output where ESLint complains about us trying to lint dot-files and folders by un-ignoring their built-in ignore filters. We agree with ignoring node_modules in terms of linting however, so that is left in place.
|
Merging to alpha, need to test this a bit in places. |
|
🎉 This PR is included in version 8.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Installing this version of cli-style I'm encountering something that I had with previous versions of cli-style as well:
Yarn why shows this:
Version in package.json is 8.0.0-alpha.4:
It seems yarn is not hoising eslint-plugin-prettier to the top level of node_modules, but instead installing it under @dhis2/cli-style/node_modules. Which seems all right, but apparently we're not able to resolve it. Maybe the resolver for eslint is starting from the root of the repo that has installed cli-style, and that's why it can't find this dependency? |
|
Installing eslint-plugin-prettier to the top-level node_modules seems to resolve the above. Probably worth creating a separate issue for, seems we encountered this issue last week as well: https://dhis2.slack.com/archives/CJF3MDK8Q/p1615472076142100. So I've tested the alpha. Without changing anything to the rules this is what I'm getting:
Two things stood out to me:
Pushed an example branch here: dhis2/scheduler-app#144 |
ghost
mentioned this pull request
Ugh. Yeah.
Yeah. Everything has been tuned to only consider errors, so that there are weird cases here makes sense, but not ready for prime time. :) Thanks for trying it out! |
Sure thing 👍! Let me know if I can do anything to help! |
|
I'll create a Jira issue for the eslint dependency issue. |
This removes the `--quiet` flag from the ESLint invocation, and fixes the broken output where ESLint complains about us trying to lint dot-files and folders by un-ignoring their built-in ignore filters. We agree with ignoring node_modules in terms of linting however, so that is left in place.
# [8.0.0](v7.3.0...v8.0.0) (2021-05-05) ### Bug Fixes * allow eslint to print colors ([#384](#384)) ([c95a184](c95a184)) * ignore .d2 directory ([#386](#386)) ([6a473f2](6a473f2)) * match files from project root ([b77ef35](b77ef35)) * wrong hooks where installed by default ([#385](#385)) ([3ac82f4](3ac82f4)) ### Code Refactoring * remove husky ([752b944](752b944)) ### Features * commit check can read from a custom file ([366be0c](366be0c)) * delete deprecated configuration files ([c961647](c961647)) * lint file system for consistent names ([#379](#379)) ([2bfb5ef](2bfb5ef)) * new and improved d2-style ([#378](#378)) ([f8279e5](f8279e5)) * opt-in git hooks ([#333](#333)) ([a3bc415](a3bc415)) * show eslint warnings ([#368](#368)) ([abe4668](abe4668)) ### BREAKING CHANGES * The verb (check/apply) is now moved to the top-level. E.g. "d2-style js check" becomes "d2-style check js". This is to allow all checkers to run with a single command: "d2-style check" * "d2-style install" is no longer used to set up linters. As of husky@5 the tool is vastly simplified and much faster. Hooks can be installed manually with "d2-style install", but is also run as a "post-install" script that we control for consistency. Configuration is added to the project with the "d2-style add" command. * Husky has been removed from cli-style. You will need to remove hooks that reference husky.sh in .git/hooks.
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This removes the
--quietflag from the ESLint invocation, and fixesthe broken output where ESLint complains about us trying to lint
dot-files and folders by un-ignoring their built-in ignore filters.
We agree with ignoring node_modules in terms of linting however, so that
is left in place.
Supersedes: #367
Supersedes: #366