Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: complete translations (DHIS2-8894) #462

Merged
merged 21 commits into from
Jun 2, 2020

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented May 28, 2020

Part of fix for https://jira.dhis2.org/browse/DHIS2-8894

Same translation fixes as in v34 branch: #438 except:

  • does not include period selector as that is being handled separately.
  • no need for old d2-i18n-extract and localize npm script as the cli scripts take care of the string extract/generating

Copy link
Contributor

@martinkrulltott martinkrulltott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @jenniferarnesen have you tested this locally with DV and Dashboards?

src/components/DataDimension/Groups.js Outdated Show resolved Hide resolved
@martinkrulltott martinkrulltott changed the title fix: complete translations fix: complete translations (DHIS2-8894) May 29, 2020
@martinkrulltott martinkrulltott self-requested a review May 29, 2020 12:20
@jenniferarnesen
Copy link
Collaborator Author

@jenniferarnesen have you tested this locally with DV and Dashboards?

Yes of course.

@jenniferarnesen jenniferarnesen merged commit f1a1fbc into master Jun 2, 2020
@jenniferarnesen jenniferarnesen deleted the chore/complete-translations-master branch June 2, 2020 19:42
dhis2-bot added a commit that referenced this pull request Jun 2, 2020
## [6.0.3](v6.0.2...v6.0.3) (2020-06-02)

### Bug Fixes

* complete translations ([#462](#462)) ([f1a1fbc](f1a1fbc))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants