Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export colors module so that DV can use it #33

Closed
wants to merge 1 commit into from

Conversation

janhenrikoverland
Copy link
Collaborator

  • Export colors module

Copy link
Collaborator

@jenniferarnesen jenniferarnesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to migrate to the theme being exported from ui-core instead of trying to maintain our own colors.

https://github.com/dhis2/ui-core/blob/master/src/theme.js

@edoardo
Copy link
Member

edoardo commented Jul 2, 2019

@cooper-joe provided the following color codes mapping between the colors file and ui-core theme
colors:

const accentPrimaryDark = '#004BA0' -> primary800
const accentPrimary = '#1976D2' -> primary600
const accentPrimaryLight = '#63A4FF' -> primary300
const accentPrimaryLightest = '#EAF4FF' -> primary050

const accentSecondaryDark = '#004C40' -> secondary800
const accentSecondary = '#00796B' -> secondary600
const accentSecondaryLight = '#48A999' -> secondary300
const accentSecondaryLightest = '#B2DFDB' -> secondary200
const accentSecondaryTransparent = '#D9ECEB' -> secondary100

const black = '#000000' -> grey900
const greyDark = '#494949' -> grey700
const grey = '#9E9E9E' -> grey500
const greyLight = '#E0E0E0' -> grey300
const blueGrey = '#ECEFF1' -> grey200
const lightBlue = '#BBDEFB' -> blue200
const snow = '#F4F6F8' -> grey050
const white = '#FFFFFF' -> white

const negative = '#E53935' -> red500
const warning = '#F19C02' -> yellow500
const positive = '#3D9305' -> green500
const info = '#EAF4FF' -> grey300

// TODO remove these?
const paleGrey = '#FAFAFA' -> grey100
const lightGrey = '#F5F5F5' -> grey100
const charcoalGrey = '#CCCCCC' -> grey400
const blue = '#004BA0' -> blue800

@edoardo
Copy link
Member

edoardo commented Jul 2, 2019

Closing.
colors from ui-core are used directly in the apps instead.

@edoardo edoardo closed this Jul 2, 2019
@edoardo edoardo deleted the chore-export-colors branch July 2, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants