fix: helpers for full axis, locked dimension, dimension can be added to axis #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Generally I'm not sure if I agree with adding these three new methods to rulesHelper.
Internally they are sound, but should they really live here? isDimensionLocked is only an extension of isDimensionLocked, isAxisFull extends getAxisMaxNumberOfDimsByVisType and canDimensionBeAddedToAxis extends the other two. Even though these methods highly depend on the rules, what they're doing for rulesHelper though is just adding layout logic to the rules engine. Is this our preferred pattern? 🤔 @janhenrikoverland
Plus one which returns if a dimension can be added to a specific axis based on the layout rules and the current content of the axis.
Added a new one which returns a transferable dimension from a specific axis.
edoardo
force-pushed
the
fix/add-dimension-helpers
branch
from
06efc61 to
cfeecbe
Compare
martinkrulltott
approved these changes
Jan 23, 2020
dhis2-bot
added a commit
that referenced
this pull request
Jan 24, 2020
## [2.8.5](v2.8.4...v2.8.5) (2020-01-24) ### Bug Fixes * helpers for full axis, locked dimension, dimension can be added to axis ([#253](#253)) ([2d6b68f](2d6b68f))
|
🎉 This PR is included in version 2.8.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used when a dimension is added/moved/dragged in the layout.
It respects the layout rules by checking the current state of the destination axis (is full, the dimension already present is locked...) to avoid incorrectly adding a dimension.