-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker build env for fedora25 #50
Conversation
The CentOS binary would also work, but can you update to Fedora 26? |
@@ -0,0 +1,18 @@ | |||
FROM fedora:25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fedora:26
now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Yes I will change it for the fedora 26. Sorry for the late reply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although based on fedora:25, this is still usable
Actually, I have tested the CentOS and my build. They both work the same. But this is a more obvious approach to broader public :). Comments from Reviewable |
Is this PR still relevant? Or can we close it? |
If the project gets transfered to the docker-machines organization we can
have a new look at this =>
#67
|
I am closing this PR. It is no longer relevant. |
I have added support for Fedora25, since I needed it.
If it fits Your plan, would You kindly merge it? I will be happy to maintain further versions.
Best regards,
Petr
This change is