Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development v5 #38

Merged
merged 17 commits into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
build:
docker:
# specify the version you desire here
- image: circleci/node:10.5
- image: circleci/node:14

# Specify service dependencies here if necessary
# CircleCI maintains a library of pre-built images
Expand Down Expand Up @@ -37,7 +37,7 @@ jobs:
# run tests
- run:
name: Testing
command: npm run all
command: npm run ci
# lint
- run:
name: lint
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:10
RUN npm i -D tap-junit@4.0.0
FROM node:14
RUN npm i -D tap-junit@5.0.0
WORKDIR /io
ENTRYPOINT [ "sh", "/node_modules/.bin/tap-junit" ]
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ The above will create a file called `tape.xuni` in the `output/tests` directory

## Output

Tap-Junit currently follows [this spec](https://github.com/junit-team/junit5/blob/main/platform-tests/src/test/resources/jenkins-junit.xsd) on junit syntax/layout

```xml
<testsuites tests="4" name="Tap-Junit" failures="2">
<testsuite tests="4" failures="2" skipped="1">
Expand All @@ -59,3 +61,11 @@ The above will create a file called `tape.xuni` in the `output/tests` directory
</testsuite>
</testsuites>
```

## Comments

So Tap Junit takes a [tape]() style assumption when it comes to comments. That being, when a comment appears before a test (because that's how tape labels its tap output) it will be registered as a comment for that test, but the issue here is that you may lose placed comments in your tap files.

At the moment, I'm still trying to figure out a decent way to handle comments and record them. Keep this in mind that only a single comment before each test will currently be recorded for a system-out tag.

If you have ideas on how to better handle this, don't hesitate to reach out!
20 changes: 20 additions & 0 deletions changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,25 @@
# Changelog

## v5.0.0

Please report any issues or serliazation that does not follow the below spec for output! Thanks!

### BREAKING CHANGES

- Changed the output generation of tap-junit to follow [this spec](https://github.com/junit-team/junit5/blob/main/platform-tests/src/test/resources/jenkins-junit.xsd) more closely
- This means no more floating comments, they are now either in the `system-out` tag or the `message` attribute
- Changed how handling tap comments works, please see the [Comments](https://github.com/dhershman1/tap-junit#comments) section in the Readme

### Improved

- Bit of re organization of the tool
- Bumped Docker node and tap versions

### Fixed

- Broken comments on some tap outputs


## v4.2.0

### Improved
Expand Down
Loading