Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exposed headers #378

Merged
merged 3 commits into from
May 17, 2018
Merged

Add exposed headers #378

merged 3 commits into from
May 17, 2018

Conversation

perkyguy
Copy link
Contributor

As can be seen in #334, there is a weird issue when trying to expose headers and the origin request header is present. This is probably due to something going on with hapi (not quite sure where though). This PR adds a CLI option, corsExposedHeaders to allow general setting of this value.

Add corsExposedHeaders option for setting Access-Control-Exposed-Headers response header.
@perkyguy perkyguy mentioned this pull request Mar 21, 2018
@ossareh
Copy link
Contributor

ossareh commented May 17, 2018

@perkyguy I was recently caught out by needing this. It would be great if you could fix the conflict that is being reported and hopefully then @dherault could merge this in?

From my point of view this is pretty critical: this is a major difference between production lambda and serverless-offline lambda. Hapi doesn't actually respect the fact that this header is set - it simply overwrites whatever is there; IMHO it would be more correct to take what's there and then append their headers.

I fully respect #304, and I'd happily help out - except this is already done and just needs a merge and a version publish :)

@perkyguy
Copy link
Contributor Author

I believe I now have the power to do the merge, maybe not the publish though. However, I'm looking for someone to review this first. @dherault, I'm not sure if that's the protocol or not (or if I'm mistaken about my granted privilages), so let me know.

@dherault
Copy link
Owner

Yes @perkyguy you could have merged it :) v3.22.0

@dherault dherault merged commit fe35acd into dherault:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants