Fix default response template #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR, please consider #304 |
|
Duplicate of #285 ? Thank you @patrickheeney anyway |
|
Thank you for your contribution! v3.16.0 |
|
Its not a duplicate. Look at the commit history. I also covered this in the
PR message.
…On Mon, Sep 18, 2017 at 1:05 AM David Hérault ***@***.***> wrote:
Thank you for your contribution! v3.16.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#301 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABV4_Bap-uJdVLXPat29W1smmoCgi49qks5sjiRFgaJpZM4PLWTi>
.
|
|
My bad @patrickheeney :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time installing
serverless-offlineand a few bugs on my functions. The response template was not being set becausefep.responsewas undefined for me. It was missing a check, similar to here. Alsothis.responseContentTypeisundefinedso switched it to the correct context.The second commit fixes another bug after I got it to load the default response. Because there is an extra line break
\nit caused this line to return{'application/json': '\n' }. This caused theresponseto get sent intoVelocityand since the template is just\n, returns a blank response. Removing the line break fixes this but maybe we should strip trailing\nbefore checking if its blank?