fix: Support alb with no method conditions #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method conditions for alb event is optional, allow any method if no method conditions is specified Fixes: dherault#1623
|
close/re-open in order to run ci. |
dnalborczyk
approved these changes
Sep 26, 2023
|
thank you @frodeaa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method conditions in alb event is optional, allow any request method to be routed
to alb event handler if no method conditions are specified
Fixes: #1623
How Has This Been Tested?
Added integration tests to verify that method condition is no longer required and
any method is routed to the event handler