refactor: re-activate unicorn/no-useless-promise-resolve-reject

dherault · Sep 20, 2023 · 3b88aa0 · 3b88aa0
1 parent dfc863a
commit 3b88aa0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -71,7 +71,6 @@ module.exports = {
     'unicorn/no-null': 'off',
     'unicorn/no-static-only-class': 'off',
     'unicorn/no-unreadable-array-destructuring': 'off',
-    'unicorn/no-useless-promise-resolve-reject': 'off',
     'unicorn/no-useless-undefined': 'off',
     'unicorn/prefer-module': 'off',
     'unicorn/prefer-spread': 'off',

diff --git a/src/lambda/LambdaFunction.js b/src/lambda/LambdaFunction.js
@@ -250,7 +250,7 @@ export default class LambdaFunction {
       entries(zip.files).map(async ([filename, jsZipObj]) => {
         const fileData = await jsZipObj.async('nodebuffer')
         if (filename.endsWith('/')) {
-          return Promise.resolve()
+          return undefined
         }
         await ensureDir(join(this.#codeDir, dirname(filename)))
         return writeFile(join(this.#codeDir, filename), fileData, {

diff --git a/src/lambda/handler-runner/docker-runner/DockerContainer.js b/src/lambda/handler-runner/docker-runner/DockerContainer.js
@@ -313,7 +313,7 @@ export default class DockerContainer {
         entries(zip.files).map(async ([filename, jsZipObj]) => {
           const fileData = await jsZipObj.async('nodebuffer')
           if (filename.endsWith(sep)) {
-            return Promise.resolve()
+            return undefined
           }
           await ensureDir(join(layerDir, dirname(filename)))
           return writeFile(join(layerDir, filename), fileData, {