Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/strikethrough #461

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Feat/strikethrough #461

merged 5 commits into from
Aug 31, 2024

Conversation

nchen000
Copy link
Contributor

@nchen000 nchen000 commented Aug 19, 2024

Add the ability to display strikethrough in cell values. Defaults to false.
Close #371.

/**
* Strikethrough flag.
*/
private final Boolean strikethrough;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use primitive type boolean to be consistent with the other flags.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to primitive type boolean.

@nchen000 nchen000 requested a review from ochedru August 29, 2024 15:14
@ochedru ochedru merged commit e16b68a into dhatim:master Aug 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strikethrough not exist
2 participants