Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Stack setup to LTS 19 (GHC 9.0.2) #2524

Closed
wants to merge 2 commits into from

Conversation

mmhat
Copy link
Collaborator

@mmhat mmhat commented Jun 11, 2023

Greetings from ZuriHac!

@Gabriella439
Copy link
Collaborator

hmmm the test failures seem a bit surprising; it's not clear how they relate to the change

@mmhat
Copy link
Collaborator Author

mmhat commented Jul 17, 2023

hmmm the test failures seem a bit surprising; it's not clear how they relate to the change

I suspect that the doctest version (0.18.2; previously: 0.17) causes the trouble. I had a quick look at the changelog and the source code diff but it is not clear to me how to fix that. Someone at ZuriHac suggested to switch to cabal-docspec; I'll try that.

@mmhat
Copy link
Collaborator Author

mmhat commented Aug 19, 2023

Regarding the doctest issue: The upstream bug report is sol/doctest#327.

I tried using cabal-docspec (did not push the code to a branch yet) and while the output is much better it requires to change some tests. I am not sure if that is worth the effort if we we can get the tests running with doctest.

@mmhat
Copy link
Collaborator Author

mmhat commented Aug 19, 2023

I am closing this in favor of #2531. Supporting GHC 9.0 is IMHO not that important if we have a working setup for 9.2.

@mmhat mmhat closed this Aug 19, 2023
@mmhat mmhat deleted the ghc-9.0.2 branch December 23, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants