SOROKA-123: Добавлены даты-интервалы, даты-строки, корректная работа с DateCatalog, багфиксы #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanKuzovlev
changed the title
dice4x4
suggested changes
Sep 22, 2022
src/utils/filledProperties.ts
Outdated
| const dateEnd = el.endJD || el.startJD | ||
| const filledPropertyId = instance.id | ||
|
|
||
| if (method === "update") { |
There was a problem hiding this comment.
Не думаешь что здесь можно без дополнительного параметра в методе? Мы же можем запрос на удаление отправлять и в случае создания, не думаю что это большой оверхед, но сам метод будет точно чище
There was a problem hiding this comment.
Согласен. Исправил.
dice4x4
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.