[Mellanox] Fix retry logic on discovery of MST device #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
force-pushed
the
mlx_query_fix
branch
from
9799331
to
2244d94
Compare
vivekrnv
reviewed
Sep 27, 2024
| while [[ ("${QUERY_RETRY_COUNT}" -lt "${QUERY_RETRY_COUNT_MAX}") && ("${SPC_MST_DEV}" == "${UNKN_MST}") ]]; do | ||
| while : ; do | ||
| SPC_MST_DEV=$(GetSPCMstDevice) | ||
| ${QUERY_XML} -d ${SPC_MST_DEV} -o ${QUERY_FILE} |
There was a problem hiding this comment.
This is only adding 0.2 - 03 sec in SPC1 device under a high load. So, doesn't look a big hit to me
vivekrnv
approved these changes
Sep 27, 2024
vivekrnv
suggested changes
Sep 30, 2024
| @@ -36,12 +36,7 @@ function startplatform() { | |||
| debug "Starting Firmware update procedure" | |||
| /usr/bin/mst start --with_i2cdev | |||
|
|
|||
| local -r _MST_DEVICE="$(GetMstDevice)" | |||
There was a problem hiding this comment.
We can remove GetMstDevice method from the syncd.sh i suppose
vivekrnv
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixing retry logic when MST device is discovered. The current implementation only fetches the name of the device but doesn't verify if the device is accessible which can be confirmed by querying the device and ensuring the command passes.
Work item tracking
How I did it
Added a query command with device as parameter and ensured it passes.
How to verify it
Running upgrade tests.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)