Skip to content

Commit

Permalink
[frr]: Force disable next hop group support. (sonic-net#17344)
Browse files Browse the repository at this point in the history
Signed-off-by: Nazarii Hnydyn [email protected]

Closes sonic-net#17345

This W/A was proposed by Nvidia FRR team before the long term solution is ready.

Why I did it
A W/A to fix default route installation during LAG member flap
Work item tracking
N/A
How I did it
Disabled FRR next hop group support
How to verify it
Do LAG member flap
  • Loading branch information
nazariig authored Dec 6, 2023
1 parent 7d4f348 commit 1ff27db
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 2 deletions.
4 changes: 4 additions & 0 deletions dockers/docker-fpm-frr/docker_init.sh
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ write_default_zebra_config()
echo "no fpm use-next-hop-groups" >> $FILE_NAME
echo "fpm address 127.0.0.1" >> $FILE_NAME
}

grep -q '^no zebra nexthop kernel enable' $FILE_NAME || {
echo "no zebra nexthop kernel enable" >> $FILE_NAME
}
}

if [[ ! -z "$NAMESPACE_ID" ]]; then
Expand Down
2 changes: 2 additions & 0 deletions dockers/docker-fpm-frr/frr/zebra/zebra.conf.j2
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
{% endblock banner %}
!
{% block fpm %}
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
3 changes: 1 addition & 2 deletions platform/vs/docker-sonic-vs/frr/zebra.conf
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
no zebra nexthop kernel enable
no fpm use-next-hop-groups

fpm address 127.0.0.1

2 changes: 2 additions & 0 deletions src/sonic-bgpcfgd/tests/data/sonic-cfggen/zebra/zebra.conf
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
! file: zebra.conf
!
!
! Force disable next hop group support
no zebra nexthop kernel enable
! Uses the old known FPM behavior of including next hop information in the route (e.g. RTM_NEWROUTE) messages
no fpm use-next-hop-groups
!
Expand Down

0 comments on commit 1ff27db

Please sign in to comment.