WIP: Add support for the buffer protocol #227
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for implementing the buffer protocol via
py_class! {}
.This works by defining a magic method:
where
MyBuffer
has to implement the following trait.Remaining issues
BufferHandle
API does not allow rejecting a buffer request.BufferHandle
API does not allow keeping ownership of the memory inside the class, as I was not sure if that can be safely done.This partially fixes #190