Export python interpreter cargo variable #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An upcoming commit will add yet another line of output to the invoked Python program. Rather than continue to deal with line offsets, let's pop the line(s) that we give named values to make code easier to understand.
Previously, Python interpreter detection likely used "python", "python2", "python3" as the Python interpreter path. This works because command execution takes PATH into account. But the determined Python path is ambiguous because it relies on environment variables. This commit changes the invoked Python script to print the value of sys.executable. This value is captured and is used as the Python interpreter path.
I had a need for this feature as part of implementing a dependent crate that embeds a Python interpreter. I need that crate's build script to invoke the Python interpreter and get some extra state from it. Before this commit, it wasn't obvious which Python interpreter the python*-sys crates were actually using. You could force one via PYTHON_SYS_EXECUTABLE or you could reimplemented the logic. But for many cases, the simple thing of having the dependent crate read state from the python*-sys crate feels best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this series is to export the full path to the Python interpreter as a Cargo variable so dependent crates can access the Python that python*-sys is using.
Read the commit messages for more info.