Initialize ob_type for class type objects early #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating classes, the `ob_type` field of the class's `PyTypeObject` is statically initialized to `NULL`, and then becomes dynamically initialized to `&PyType_Type` when `PyType_Ready()` is called. This is too late. If GC occurs during the initialization of the class before `PyType_Ready()` is called, then the garbage collector will encounter the `NULL` `ob_type` and segfault. The Python docs say this field should be dynamically initialized to `&PyType_Type` before doing any more class initialization.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating classes, the
ob_typefield of the class'sPyTypeObjectis statically initialized to
NULL, and then becomes dynamicallyinitialized to
&PyType_TypewhenPyType_Ready()is called. This istoo late. If GC occurs during the initialization of the class before
PyType_Ready()is called, then the garbage collector will encounterthe
NULLob_typeand segfault.The Python docs say this field should be dynamically initialized to
&PyType_Typebefore doing any more class initialization.