Skip to content

Commit

Permalink
Fix a "former/latter" typo
Browse files Browse the repository at this point in the history
I knew I shouldn't have used "former" and "latter". I often mix it up!
  • Loading branch information
dgroomes committed Mar 30, 2021
1 parent 476d7fa commit 342fd6b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ configure(allprojects.minus(dependencyConstraints)) {
"implementation"(platform(dependencyConstraints))
}
}

4 changes: 2 additions & 2 deletions dependency-constraints/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ dependencies {
* For some reason, using the overloaded method `api(group: String, name: String, version: String)` causes the
* Gradle configuration phase to fail with the error "Adding dependencies to platforms is not allowed by default."
* So instead I am using the method `api(constraintNotation: String)`. But shouldn't I be able to use the former
* method overload? Is this a defect? From the JavaDoc, it actually suggests that the latter "adds a dependency"
* while the former "adds a dependency constraint" so that suggests it is not a defect. But from a user perspective,
* method overload? Is this a defect? From the JavaDoc, it actually suggests that the former "adds a dependency"
* while the latter "adds a dependency constraint" so that suggests it is not a defect. But from a user perspective,
* the method calls convey the same information so I would guess they should do the same thing. But they don't.
*/
// api("com.github.tomakehurst", "wiremock-jre8", wireMockVersion) // This form causes Gradle to fail
Expand Down

0 comments on commit 342fd6b

Please sign in to comment.