Skip to content

Commit

Permalink
intentionally break test command
Browse files Browse the repository at this point in the history
  • Loading branch information
dgrebb committed Jan 15, 2024
1 parent bea3364 commit 0fb3328
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 17 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/backstop-sanity-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ jobs:
echo '```diff' >> $GITHUB_STEP_SUMMARY
echo "${PUPPETEER_TEST_RESULT}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "# More" >> $GITHUB_STEP_SUMMARY
echo "$PUPPETEER_TEST_RESULT" >> $GITHUB_STEP_SUMMARY
else
echo "# ✅ Puppeteer Sanity Report Valid" >> $GITHUB_STEP_SUMMARY
fi
Expand Down Expand Up @@ -114,14 +112,12 @@ jobs:
<(jq 'walk(if type == "object" then with_entries(.value |= if type == "object" or type == "array" then . else "" end) else . end)' test/configs/backstop_data/bitmaps_test/**/report.json))
echo "PLAYWRIGHT_TEST_RESULT=$PLAYWRIGHT_TEST_RESULT" >> $GITHUB_ENV
if [[ $PLAYWRIGHT_TEST_RESULT != "" ]]; then
echo "# ❎ Playwright Sanity Report Different" >> $GITHUB_STEP_SUMMARY
echo '```diff' >> $GITHUB_STEP_SUMMARY
echo "${PLAYWRIGHT_TEST_RESULT}" >> $GITHUB_STEP_SUMMARY
echo '```' >> $GITHUB_STEP_SUMMARY
echo "# More" >> $GITHUB_STEP_SUMMARY
echo "$PLAYWRIGHT_TEST_RESULT" >> $GITHUB_STEP_SUMMARY
else
echo "# ✅ Playwright Sanity Report Valid" >> $GITHUB_STEP_SUMMARY
echo "# ❎ Playwright Sanity Report Different" >> $GITHUB_STEP_SUMMARY
fi
- name: "Full Sanity Report Diff"
Expand Down
24 changes: 12 additions & 12 deletions core/command/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ const { shouldRunDocker, runDocker } = require('../util/runDocker');
module.exports = {
execute: function (config) {
const executeCommand = require('./index');
if (shouldRunDocker(config)) {
return runDocker(config, 'test')
.finally(() => {
if (config.openReport && config.report && config.report.indexOf('browser') > -1) {
executeCommand('_openReport', config);
}
});
} else {
return createBitmaps(config, false).then(function () {
return executeCommand('_report', config);
});
}
// if (shouldRunDocker(config)) {
// return runDocker(config, 'test')
// .finally(() => {
// if (config.openReport && config.report && config.report.indexOf('browser') > -1) {
// executeCommand('_openReport', config);
// }
// });
// } else {
// return createBitmaps(config, false).then(function () {
// // return executeCommand('_report', config);
// });
// }
}
};

0 comments on commit 0fb3328

Please sign in to comment.