Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Don't use dgraph binary in tests (GRAPHQL-1144) #168

Merged
merged 1 commit into from
Apr 8, 2021
Merged

fix(test): Don't use dgraph binary in tests (GRAPHQL-1144) #168

merged 1 commit into from
Apr 8, 2021

Conversation

abhimanyusinghgaur
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur commented Apr 8, 2021 •
edited by manishrjain
Loading

Ref: dgraph-io/dgo#143

This change is Reviewable

@abhimanyusinghgaur abhimanyusinghgaur changed the title fix(test): Don't use dgraph binary in tests fix(test): Don't use dgraph binary in tests (GRAPHQL-1114) Apr 8, 2021
NamanJain8
NamanJain8 approved these changes Apr 8, 2021
View reviewed changes
Copy link

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewable status: 0 of 4 files reviewed, all discussions resolved

@abhimanyusinghgaur abhimanyusinghgaur merged commit 55cfb6a into master Apr 8, 2021
@abhimanyusinghgaur abhimanyusinghgaur deleted the abhimanyu/fix-test branch April 8, 2021 12:55
@abhimanyusinghgaur abhimanyusinghgaur changed the title fix(test): Don't use dgraph binary in tests (GRAPHQL-1114) fix(test): Don't use dgraph binary in tests (GRAPHQL-1144) Apr 8, 2021
abhimanyusinghgaur added a commit that referenced this pull request Apr 8, 2021
@abhimanyusinghgaur
chore: release v21.03.0
6510769 
### Added
* feat: add loginIntoNamespace API on clients (GRAPHQL-1058) (#166)
### Deprecated
* chore: Sync dgo + deprecate Slash endpoint method (GRAPHQL-1141) (#167)
### Fixed
* fix(test): Don't use dgraph binary in tests (GRAPHQL-1144) (#168)
@abhimanyusinghgaur abhimanyusinghgaur mentioned this pull request Apr 8, 2021
Merged
abhimanyusinghgaur added a commit that referenced this pull request Apr 8, 2021
@abhimanyusinghgaur
chore: release v21.03.0 (GRAPHQL-1144) (#169)
2ab48ce 
### Added
* feat: add loginIntoNamespace API on clients (GRAPHQL-1058) (#166)
### Deprecated
* chore: Sync dgo + deprecate Slash endpoint method (GRAPHQL-1141) (#167)
### Fixed
* fix(test): Don't use dgraph binary in tests (GRAPHQL-1144) (#168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhimanyusinghgaur @NamanJain8