fix(restore): allow incrementalFrom to be 1 in restore API #8988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangalaman93
requested review from
meghalims,
sanjayk-github-dev,
harshil-goel,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
dgraph-bot
added
area/testing
kevinmingtarja
previously approved these changes
Sep 4, 2023
mangalaman93
force-pushed
the
aman/restore
branch
from
88c4524
to
9772f30
Compare
all-seeing-code
previously approved these changes
Sep 13, 2023
kevinmingtarja
previously approved these changes
Sep 13, 2023
This is a minor inconvenience while using the incremental restore API that when incrementalFrom is set to 1, we throw an error back. The restore API takes a from backup number (incrementalFrom) and a to backup number (backupNum) and restores all the backups including both the ends, i.e. following set notation all the backups in the set [incrementalFrom, backupNum] are restored. This should work fine when incrementalFrom is set to 1 which is a full backup.
mangalaman93
dismissed stale reviews from kevinmingtarja and all-seeing-code
via
7adaaf9
mangalaman93
force-pushed
the
aman/restore
branch
from
9772f30
to
7adaaf9
Compare
shivaji-kharse
pushed a commit
that referenced
this pull request
Mar 12, 2024
This is a minor inconvenience while using the incremental restore API that when incrementalFrom is set to 1, we throw an error back. The restore API takes two backup numbers incrementalFrom & backupNum and restores all the backups including both the ends, i.e. following set notation all the backups in the set [incrementalFrom, backupNum] are restored. This should work fine when incrementalFrom is set to 1 which is a full backup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor inconvenience while using the incremental restore API that when incrementalFrom is set to 1, we throw an error back. The restore API takes two backup numbers incrementalFrom & backupNum and restores all the backups including both the ends, i.e. following set notation all the backups in the set [incrementalFrom, backupNum] are restored. This should work fine when incrementalFrom is set to 1 which is a full backup.