Added lang support #8924
Merged
Added lang support #8924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshil-goel
requested review from
mangalaman93,
meghalims,
sanjayk-github-dev,
all-seeing-code,
billprovince and
joshua-goldstein
as code owners
|
|
dgraph-bot
added
area/testing
| @@ -2275,7 +2285,8 @@ func getNonIDFields(schema *ast.Schema, defn *ast.Definition, providesTypeMap ma | |||
| return append(fldList, pd) | |||
| } | |||
|
|
|||
| func getFieldsWithoutIDType(schema *ast.Schema, defn *ast.Definition, providesTypeMap map[string]bool) ast.FieldList { | |||
| func getFieldsWithoutIDType(schema *ast.Schema, defn *ast.Definition, | |||
| providesTypeMap map[string]bool, isAddingInput bool) ast.FieldList { | |||
There was a problem hiding this comment.
What does the parameter isAddingInput mean?
mangalaman93
requested changes
Aug 8, 2023
| // We don't include fields in update patch, which corresponds to multiple language tags in dgraph | ||
| // Example, nameHi_En: String @dgraph(pred:"Person.name@hi:en") | ||
| // We don't add above field in update patch because it corresponds to multiple languages | ||
| if isMultiLangField(fld, true) { |
There was a problem hiding this comment.
did we add a test for this case?
There was a problem hiding this comment.
Already present tests: graphql/e2e/directives/schema.graphql
mangalaman93
requested changes
Aug 23, 2023
| @@ -1905,7 +1910,7 @@ func addAggregationResultType(schema *ast.Schema, defn *ast.Definition, provides | |||
| } | |||
|
|
|||
| // Adds titleMax, titleMin fields for a field of name title. | |||
| if isOrderable(fld, defn, providesTypeMap) { | |||
| if isOrderable(fld, defn, providesTypeMap) || isMultiLangField(fld, false) { | |||
There was a problem hiding this comment.
isOrderable function already checks for isMultiLandField. Do we need to do it again here?
There was a problem hiding this comment.
Yes, fails some tests
harshil-goel
force-pushed
the
harshil-goel/lang-support
branch
from
dfdd0d3
to
bf5afe5
Compare
harshil-goel
force-pushed
the
harshil-goel/lang-support
branch
from
dfaf387
to
49cd7d0
Compare
added 2 commits
September 27, 2023 20:52
harshil-goel
force-pushed
the
harshil-goel/lang-support
branch
from
49cd7d0
to
4841777
Compare
joshua-goldstein
approved these changes
Sep 27, 2023
jairad26
approved these changes
Sep 28, 2023
mangalaman93
approved these changes
Oct 13, 2023
shivaji-kharse
pushed a commit
that referenced
this pull request
Mar 12, 2024
Added lang support to GraphQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added lang support to GraphQL