Generic alpha log error message for failed ACL login #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…printed in alpha logs
jarifibrahim
approved these changes
Nov 5, 2020
OmarAyo
added a commit
that referenced
this pull request
Nov 5, 2020
* In case of an invalid login request, a generic error message will be printed in alpha logs * used x.ErrorInvalidLogin per Ibrahim's suggestion (cherry picked from commit 7088d59)
OmarAyo
added a commit
that referenced
this pull request
Nov 5, 2020
* In case of an invalid login request, a generic error message will be printed in alpha logs * used x.ErrorInvalidLogin per Ibrahim's suggestion (cherry picked from commit 7088d59)
OmarAyo
added a commit
that referenced
this pull request
Nov 5, 2020
OmarAyo
added a commit
that referenced
this pull request
Nov 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an invalid login request, we don't reveal info about user. So made the error message more generic in alpha logs.
This change is