Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick: Don't reserve certain queries/mutations/inputs when a type is remote. #6201

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Cherrypick: Don't reserve certain queries/mutations/inputs when a type is remote. #6201

merged 1 commit into from
Aug 17, 2020

Conversation

pawanrawal
Copy link
Contributor

@pawanrawal pawanrawal commented Aug 17, 2020 •
edited by dgraph-bot
Loading

Fixes the issue mentioned in https://discuss.dgraph.io/t/custom-directive-issue-documentation-related/8885 where certain identifiers were incorrectly reserved even though they shouldn't have been.

(cherry picked from commit 9b67c2f)

This change is Reviewable

Docs Preview: Dgraph Preview

@pawanrawal
fix(GraphQL): Don't reserve certain queries/mutations/inputs when a t…
6758857 
…ype is remote. (#6055)

Fixes the issue mentioned in https://discuss.dgraph.io/t/custom-directive-issue-documentation-related/8885 where certain identifiers were incorrectly reserved even though they shouldn't have been.

(cherry picked from commit 9b67c2f)
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Aug 17, 2020
abhimanyusinghgaur
abhimanyusinghgaur approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @MichaelJCompton)

@pawanrawal pawanrawal merged commit 025891e into release/v20.07 Aug 17, 2020
@pawanrawal pawanrawal deleted the pawanrawal/cherrypick-remote-types-issue branch August 17, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimanyusinghgaur abhimanyusinghgaur abhimanyusinghgaur approved these changes

@MichaelJCompton MichaelJCompton Awaiting requested review from MichaelJCompton

Assignees
No one assigned
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pawanrawal @abhimanyusinghgaur