fix(GraphQL): multiple queries in a single request should not share the same variables (#5953) #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same variables (#5953) Fixes GraphQL-570. Earlier, sending a query like this: ``` query ($filter: CountryFilter!){ qc0: queryCountry(filter: $filter) { id name } qc1: queryCountry(filter: $filter) { id name } } ``` where $filter is a GraphQL variable as below: ``` { "filter": { "id": [ "0x0" ] } } ``` would fetch you results like this: ``` "data": { "qc0": [ { "id": "0x2711", "name": "India" }, { "id": "0x2712", "name": "Australia" }, { "id": "0x2713", "name": "US" } ], "qc1": [] } ``` While you should have got empty results for both the queries as `0x0` is not a uid that exists. This PR fixes the above bug by doing a deep-copy of field arguments if variables are provided, so avoiding sharing the same memory address across all the queries in a request. Hence, avoiding any bugs that could be caused as a result of modification of that shared memory address. (cherry picked from commit 58e90aa)
abhimanyusinghgaur
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Aug 11, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GraphQL-570.
Earlier, sending a query like this:
where $filter is a GraphQL variable as below:
would fetch you results like this:
While you should have got empty results for both the queries as
0x0is not a uid that exists.This PR fixes the above bug by doing a deep-copy of field arguments if variables are provided, so avoiding sharing the same memory address across all the queries in a request. Hence, avoiding any bugs that could be caused as a result of modification of that shared memory address.
(cherry picked from commit 58e90aa)
This change is
Docs Preview: