Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(GraphQL): Nested auth queries no longer search through all possible records (#5666) #5950

Merged
merged 4 commits into from
Jul 14, 2020

Conversation

arijitAD
Copy link

@arijitAD arijitAD commented Jul 13, 2020

Fixes GRAPHQL-427(Release blocker)

Previously auth queries had type filter for all levels and hence it would fetch all nodes of a particular type. This PR only applies auth on the nodes that are part of the parent query. Hence, touching same/less number of nodes as it would have in the query without auth rules.

(cherry picked from commit 222f42a)


This change is Reviewable

Docs Preview: Dgraph Preview

…ble records (#5666)

Previously auth queries had type filter for all levels and hence it would fetch all nodes of a particular type. This PR only applies auth on the nodes that are part of the parent query. Hence, touching same/less number of nodes as it would have in the query without auth rules.

(cherry picked from commit 222f42a)
@parasssh parasssh merged commit e34517e into release/v20.07 Jul 14, 2020
@arijitAD arijitAD deleted the arijitAD/20.07_auth_nested_optimize branch July 14, 2020 01:09
@amaster507
Copy link
Contributor

This made a world of difference! Took a 9 second query down to a 869ms query. Excellent work! Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants