Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-picked from commit b05c525873c1c007a6ff4340e3d91fc2ceb96865 #5557

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

parasssh
Copy link
Contributor

@parasssh parasssh commented Jun 1, 2020

dont set n.ops map entries to nil. Instead just delete them (#5551)

A panic was caused because n.ops map entry was set to nil in some cases.
Fix is to not set n.ops map entries to nil. Instead, just delete them.
Fixed DGRAPH-1573


This change is Reviewable

Docs Preview: Dgraph Preview

dont set n.ops map entries to nil. Instead just delete them (#5551)

A panic was caused because n.ops map entry was set to nil in some cases.
Fix is to not set n.ops map entries to nil. Instead, just delete them.
Fixed DGRAPH-1573
@parasssh parasssh requested review from manishrjain and a team as code owners June 1, 2020 18:52
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@parasssh parasssh merged commit c07a6d4 into release/v20.03 Jun 3, 2020
@parasssh parasssh deleted the paras/v2003_jira_1573 branch June 3, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants