Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/v20.03: Alpha: Enable bloom filter caching (#5552) #5555

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Jun 1, 2020

Badger supports the caching of SST bloom filters. This PR enables
caching bloom filters in ristretto. The bloom filter cache is enabled
only for the p directory. The bloom filters for the w directory will be
kept in memory. We can add caching for it later if necessary.

This PR also removes old stale todos.

(cherry picked from commit 92328a7)


This change is Reviewable

Docs Preview: Dgraph Preview

Badger supports the caching of SST bloom filters. This PR enables
caching bloom filters in ristretto. The bloom filter cache is enabled
only for the p directory. The bloom filters for the w directory will be
kept in memory. We can add caching for it later if necessary.

This PR also removes old stale todos.

(cherry picked from commit 92328a7)
@jarifibrahim jarifibrahim requested review from manishrjain and a team as code owners June 1, 2020 15:15
@jarifibrahim jarifibrahim changed the title Alpha: Enable bloom filter caching (#5552) release/v20.03: Alpha: Enable bloom filter caching (#5552) Jun 1, 2020
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm_strong:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@jarifibrahim jarifibrahim merged commit 67ee6e2 into release/v20.03 Jun 8, 2020
@jarifibrahim jarifibrahim deleted the ibrahim/r20.03-bf-cache branch June 8, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants