Add check on rebalance interval #5544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all-seeing-code
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
pawanrawal
approved these changes
May 29, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
ashish-goswami
approved these changes
May 29, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
all-seeing-code
added a commit
that referenced
this pull request
Jun 8, 2020
(cherry picked from commit fa5c3a3)
all-seeing-code
added a commit
that referenced
this pull request
Jun 8, 2020
(cherry picked from commit fa5c3a3)
all-seeing-code
added a commit
that referenced
this pull request
Jun 9, 2020
all-seeing-code
added a commit
that referenced
this pull request
Jun 9, 2020
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DGRAPH-1368
Exit gracefully and prevent panic in zero if non-positive rebalance interval duration is passed.
This change is