graphql: Fix mutation on predicate with special characters having dgraph directive.

[arijitAD]

Fixes GRAPHQL-411.
Fixes #5296

---

This change is 

Docs Preview:

[pawanrawal]

Could we also add an end to test which mutates some data for such a predicate and then queries it back? You can even update one of such existing mutation e2e tests if that is easier.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @arijitAD and @MichaelJCompton)

---

graphql/resolve/mutation_rewriter.go, line 1006 at r1 (raw file):

			fieldDef := typ.Field(field)
			fieldName := typ.DgraphPredicate(field)
			if strings.HasPrefix(fieldName, "<") && strings.HasSuffix(fieldName, ">") {

This should probably not be here as this happens at mutation rewriting time. We should have this in wrappers.go where we compute this mapping on schema update.

---

graphql/resolve/schema.graphql, line 212 at r1 (raw file):

type Message {
  content: String! @dgraph(pred: "post")

Could you please fix the indentation on this one?

---

graphql/resolve/schema.graphql, line 213 at r1 (raw file):

type Message {
  content: String! @dgraph(pred: "post")
  author: String @dgraph(pred: "<职业>")

What happens if this didn't have <> and just had special characters, would that work fine?

---

graphql/schema/gqlschema_test.yml, line 1993 at r1 (raw file):

      }

  - name: "@dgraph predicate type validation gives no errors with non-null variations"

Look like this was a duplicate test?

[arijitAD]

Reviewable status: 4 of 9 files reviewed, 4 unresolved discussions (waiting on @MichaelJCompton and @pawanrawal)

---

graphql/resolve/mutation_rewriter.go, line 1006 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

This should probably not be here as this happens at mutation rewriting time. We should have this in wrappers.go where we compute this mapping on schema update.

We would still be using <> for the predicate when querying. Hence, if I make the change in wrapper.go it might query the wrong predicate.

---

graphql/resolve/schema.graphql, line 212 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Could you please fix the indentation on this one?

Done.

---

graphql/resolve/schema.graphql, line 213 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

What happens if this didn't have <> and just had special characters, would that work fine?

This is something that Dgraph recommends.
https://dgraph.io/docs/query-language/#predicates-i18n

---

graphql/schema/gqlschema_test.yml, line 1993 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Look like this was a duplicate test?

Yes

[pawanrawal]

Approving but ideally the mutation in e2e tests should be a GraphQL mutation and not a GraphQL+- one. We do that for other data also like starship etc, so you should be able to add that easily.

Reviewed 7 of 7 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @arijitAD and @MichaelJCompton)

---

graphql/e2e/common/query.go, line 1478 at r2 (raw file):

		}`,
	}
	result := "{\"queryMessage\":[{\"content\":\"content1\",\"author\":\"author1\"}]}"

You can use `` and then you don't need to escape the double quotes. Makes for cleaner code.

---

graphql/e2e/directives/test_data.json, line 104 at r2 (raw file):

    },
    {
        "uid":"_:Message1",

We should be adding this test data using a GraphQL mutation (like addMessage) to test the mutation logic end to end. Right now it's just doing a Dgraph mutation which doesn't do any of the query rewritings.

---

graphql/resolve/mutation_rewriter.go, line 1006 at r1 (raw file):

Previously, arijitAD (Arijit Das) wrote…

We would still be using <> for the predicate when querying. Hence, if I make the change in wrapper.go it might query the wrong predicate.

Yeah, agreed.

[arijitAD]

Reviewable status: 6 of 9 files reviewed, 3 unresolved discussions (waiting on @MichaelJCompton and @pawanrawal)

---

graphql/e2e/common/query.go, line 1478 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

You can use `` and then you don't need to escape the double quotes. Makes for cleaner code.

Done.

---

graphql/e2e/directives/test_data.json, line 104 at r2 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

We should be adding this test data using a GraphQL mutation (like addMessage) to test the mutation logic end to end. Right now it's just doing a Dgraph mutation which doesn't do any of the query rewritings.

Done.

---

graphql/resolve/mutation_rewriter.go, line 1006 at r1 (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

Yeah, agreed.

Done.